Re: [PATCH] staging: rtl8723bs: drop redundant conversion to bool

[Dan Carpenter]

On Wed, Aug 27, 2025 at 11:15:00AM +0800, Xichao Zhao wrote:
> The result of integer comparison already evaluates to bool. No need for
> explicit conversion.
> 
> No functional impact.
> 
> Signed-off-by: Xichao Zhao <zhao.xichao@xxxxxxxx>
> ---
>  drivers/staging/rtl8723bs/core/rtw_mlme.c        | 6 +++---
>  drivers/staging/rtl8723bs/os_dep/osdep_service.c | 4 ++--
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> index 692d0c2b766d..570c99192d3f 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> @@ -1597,7 +1597,7 @@ inline bool rtw_is_scan_deny(struct adapter *adapter)
>  {
>  	struct mlme_priv *mlmepriv = &adapter->mlmepriv;
>  
> -	return (atomic_read(&mlmepriv->set_scan_deny) != 0) ? true : false;
> +	return (atomic_read(&mlmepriv->set_scan_deny) != 0);


mlmepriv->set_scan_deny is either 0 or 1 so it's cleaner to just do:

	return atomic_read(&mlmepriv->set_scan_deny);

(avoids the double negative).

regards,
dan carpenter