Re: [PATCH v8 1/5] cdx: add the headers to include/linux

[Borislav Petkov]

On Tue, Aug 26, 2025 at 10:59:10AM +0530, Shubhrajyoti Datta wrote:
> Subject: Re: [PATCH v8 1/5] cdx: add the headers to include/linux

Make that title more specific:

"cdx: Split mcdi.h and reorganize headers"

or so.

> Move `bitfield.h` from the CDX controller directory to
> `include/linux/cdx` to make them accessible to other drivers.
> 
> As part of this refactoring, `mcdi.h` has been split into two headers:
> - `mcdi.h`: retains interface-level declarations
> - `mcdid.h`: contains internal definitions and macros
> 
> This is in preparation for VersalNET EDAC
> driver that relies on it.
> 
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxx>
> ---
> 
> Changes in v8:
> - Split `mcdi.h` into `mcdi.h` and `mcdid.h`
> - Removed common code from CDX headers
> - Used refactored versions from shared location
> 
> Changes in v7:
> - add a minimal header instead moving them
> 
> Changes in v6:
>  - Patch added
> 
>  drivers/cdx/controller/cdx_controller.c       |  2 +-
>  drivers/cdx/controller/cdx_rpmsg.c            |  2 +-
>  drivers/cdx/controller/mcdi.c                 |  5 +-
>  drivers/cdx/controller/mcdi_functions.c       |  1 -
>  drivers/cdx/controller/mcdi_functions.h       |  3 +-
>  drivers/cdx/controller/mcdid.h                | 65 +++++++++++++++++++
>  .../linux/cdx}/bitfield.h                     |  0
>  .../controller => include/linux/cdx}/mcdi.h   | 52 +--------------
>  8 files changed, 73 insertions(+), 57 deletions(-)
>  create mode 100644 drivers/cdx/controller/mcdid.h
>  rename {drivers/cdx/controller => include/linux/cdx}/bitfield.h (100%)
>  rename {drivers/cdx/controller => include/linux/cdx}/mcdi.h (74%)

I'd need an Ack from these gents:

Nipun Gupta <nipun.gupta@xxxxxxx> (maintainer:AMD CDX BUS DRIVER)
Nikhil Agarwal <nikhil.agarwal@xxxxxxx> (maintainer:AMD CDX BUS DRIVER,commit_signer:4/6=67%)

if this is going to go through the EDAC tree.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette