Re: [PATCH net-next v11 08/16] net: phy: Introduce generic SFP handling for PHY drivers

[Simon Horman]

On Thu, Aug 14, 2025 at 03:58:23PM +0200, Maxime Chevallier wrote:

...

> diff --git a/include/linux/phy_port.h b/include/linux/phy_port.h
> index f47ac5f5ef9e..697721a6239f 100644
> --- a/include/linux/phy_port.h
> +++ b/include/linux/phy_port.h
> @@ -67,6 +67,7 @@ struct phy_port {
>  	unsigned int not_described:1;
>  	unsigned int active:1;
>  	unsigned int is_mii:1;
> +	unsigned int is_sfp:1;

nit: Please also add is_spf to the Kernel doc for this structure.


>  };
>  
>  struct phy_port *phy_port_alloc(void);
> -- 
> 2.49.0
>