Re: [PATCH net-next 6/7] net: stmmac: enhance VLAN protocol detection for GRO

[Simon Horman]

On Tue, Aug 26, 2025 at 01:32:46PM +0200, Konrad Leszczynski wrote:
> From: Piotr Warpechowski <piotr.warpechowski@xxxxxxxxx>
> 
> Enhance protocol extraction in stmmac_has_ip_ethertype() by introducing
> MAC offset parameter and changing:
> 
> __vlan_get_protocol() ->  __vlan_get_protocol_offset()
> 
> Add correct header length for VLAN tags, which enable Generic Receive
> Offload (GRO) in VLAN.
> 
> Co-developed-by: Karol Jurczenia <karol.jurczenia@xxxxxxxxx>
> Signed-off-by: Karol Jurczenia <karol.jurczenia@xxxxxxxxx>
> Reviewed-by: Konrad Leszczynski <konrad.leszczynski@xxxxxxxxx>
> Reviewed-by: Sebastian Basierski <sebastian.basierski@xxxxxxxxx>
> Signed-off-by: Piotr Warpechowski <piotr.warpechowski@xxxxxxxxx>

Konrad,

As per my comment on an earlier patch, your SoB line needs to go here.

Otherwise, this looks good to me.

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>

...