Re: [PATCH 2/2] io_uring/kbuf: fix infinite loop in io_kbuf_inc_commit()

From: Keith Busch
Date: Wed Aug 27 2025 - 17:59:38 EST


On Wed, Aug 27, 2025 at 03:45:28PM -0600, Jens Axboe wrote:
> > + buf_len = READ_ONCE(buf->len);
> > + this_len = min_t(int, len, buf_len);
> > + buf_len -= this_len;
> > + if (buf_len) {
> > buf->addr += this_len;
> > + buf->len = buf_len;
> > return false;
> > }
> > + buf->len = 0;

Purely for symmetry, assigning buf->len ought to be a WRITE_ONCE.