Re: [PATCH net-next v3 2/2] net: phy: micrel: Add PTP support for lan8842

[Jakub Kicinski]

On Tue, 26 Aug 2025 09:11:00 +0200 Horatiu Vultur wrote:
> +#define LAN8842_STRAP_REG_PHYADDR_MASK		GENMASK(4, 0)

> +	addr = lanphy_read_page_reg(phydev, LAN8814_PAGE_COMMON_REGS,
> +				    LAN8842_STRAP_REG);
> +	addr &= LAN8842_STRAP_REG_PHYADDR_MASK;
> +	if (addr < 0)
> +		return addr;

Did you mean to mask the value after the check if it's negative?