Re: [PATCH net-next v3 1/2] net: phy: micrel: Introduce function __lan8814_ptp_probe_once

[Horatiu Vultur]

The 08/27/2025 17:49, Jakub Kicinski wrote:
> 
> On Tue, 26 Aug 2025 09:10:59 +0200 Horatiu Vultur wrote:
> > -static int lan8814_ptp_probe_once(struct phy_device *phydev)
> > +static int __lan8814_ptp_probe_once(struct phy_device *phydev, char *pin_name,
> > +                                 size_t gpios)
> 
> nit: size_t for gpios seems excessive, n_pins is an int. I'm guessing
> you chose it based on kmalloc_array() arg type but, yeah, not sure it
> makes sense within this context..

Yes, that is why I have chosen size_t. But I will update it in the next
version.


-- 
/Horatiu