Re: [PATCH v2 2/2] ASoC: spacemit: add i2s support for K1 SoC

[Mark Brown]

On Thu, Aug 28, 2025 at 11:37:33AM +0800, Troy Mitchell wrote:

> +	switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
> +	case SND_SOC_DAIFMT_DSP_A:
> +	case SND_SOC_DAIFMT_DSP_B:
> +		cpu_dai->driver->playback.channels_min = 1;
> +		cpu_dai->driver->playback.channels_max = 1;

> +	if ((fmt & SND_SOC_DAIFMT_FORMAT_MASK) == SND_SOC_DAIFMT_DSP_A)
> +		sspsp_val |= SSPSP_FSRT;

It's weird and confusing that this isn't part of the above switch case.

> +static void spacemit_i2s_remove(struct platform_device *pdev)
> +{
> +	/* resources auto-freed by devm_ */
> +}

If this can be empty remove it.

Attachment: signature.asc
Description: PGP signature