Re: [PATCH] platform/x86: asus-wmi: Fix racy registrations
From: Ilpo Järvinen
Date: Thu Aug 28 2025 - 12:21:15 EST
On Wed, 27 Aug 2025 07:24:33 +0200, Takashi Iwai wrote:
> asus_wmi_register_driver() may be called from multiple drivers
> concurrently, which can lead to the racy list operations, eventually
> corrupting the memory and hitting Oops on some ASUS machines.
> Also, the error handling is missing, and it forgot to unregister ACPI
> lps0 dev ops in the error case.
>
> This patch covers those issues by introducing a simple mutex at
> acpi_wmi_register_driver() & *_unregister_driver, and adding the
> proper call of asus_s2idle_check_unregister() in the error path.
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.
The list of commits applied:
[1/1] platform/x86: asus-wmi: Fix racy registrations
commit: 5549202b9c02c2ecbc8634768a3da8d9e82d548d
--
i.