Re: [PATCH v5] mm/zswap: store <PAGE_SIZE compression failed page as-is

From: SeongJae Park
Date: Thu Aug 28 2025 - 12:41:20 EST


On Wed, 27 Aug 2025 14:16:37 -0700 Chris Li <chrisl@xxxxxxxxxx> wrote:

> On Wed, Aug 27, 2025 at 10:45 AM SeongJae Park <sj@xxxxxxxxxx> wrote:
[...]
> Anyway, I just opened the editor to check again. Yes, if we goto the
> read_done, the if condition using dlen can introduce a new incoming
> edge that has len uninitialized value to be used. Yes, need to
> initialize dlen = PAGE_SIZE or you initialize it at the memcpy of
> page.

Thank you for confirming.

>
> > I will post the fixup by tomorrow morning (Pacific time) unless I
> > hear other opinions or find my mistakes on the above plan by tonight.
>
> You are too humble, that is the normal reviewing process. You can take
> your time.

No worry, I just wanted to give you an expectation of the time line :)

Andrew, could you please pick the below attached cleanup patch as a fixup of
the original patch? Please feel free to let me know if you prefer posting a
new version of the patch instead or any other approach.


Thanks,
SJ

[...]

==== Attachment 0 (0001-mm-zswap-cleanup-incompressible-pages-handling-code.patch) ====