Re: [PATCH v7 1/1] selftests/mm/uffd: Refactor non-composite global vars into struct
From: Liam R. Howlett
Date: Thu Aug 28 2025 - 14:50:40 EST
* Brendan Jackman <jackmanb@xxxxxxxxxx> [250828 08:37]:
> On Sun Aug 17, 2025 at 6:52 AM UTC, Ujwal Kundur wrote:
> > -static void noop_alias_mapping(__u64 __unused *start, size_t __unused len,
> > - unsigned long __unused offset)
> > +static void noop_alias_mapping(uffd_global_test_opts_t *gopts, __u64 __unused *start,
> > + size_t __unused len, unsigned long __unused offset)
>
> After a rebase this is now falling afoul of the -Wunused-parameter added
> here:
>
> https://lore.kernel.org/all/20250731160132.1795351-5-usama.anjum@xxxxxxxxxxxxx/T/#m0449dc0d6a5ac3b1f71f7182c13b6829e1b444cf
>
> I really don't think we want that flag, I'll comment on that thread, but
> just as an FYI here too.
I was under the impression that it was decided to drop that flag,
otherwise I would have also spoken up about it.