Re: [PATCH v3 1/3] platform/x86: think-lmi: Add certificate GUID structure

[Mark Pearson]

On Thu, Aug 28, 2025, at 6:50 AM, Ilpo Järvinen wrote:
> On Mon, 25 Aug 2025, Mark Pearson wrote:
>
>> Add a certificate GUID structure to make it easier to add different
>> options for other platforms that need different GUIDs.
>> 
>> Suggested-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
>> Signed-off-by: Mark Pearson <mpearson-lenovo@xxxxxxxxx>
>> ---
>> Changes in v2:
>>  - split patch up into series
>> Changes in v3:
>>  - add field details to thinkpad_cert_guid declare.
>>  - add missing comma
>>  - Move null thumbprint GUID check to later in series
>> 
>>  drivers/platform/x86/lenovo/think-lmi.c | 38 +++++++++++++++++++------
>>  1 file changed, 30 insertions(+), 8 deletions(-)
>> 
>> diff --git a/drivers/platform/x86/lenovo/think-lmi.c b/drivers/platform/x86/lenovo/think-lmi.c
>> index 0992b41b6221..a22d25f6d3c6 100644
>> --- a/drivers/platform/x86/lenovo/think-lmi.c
>> +++ b/drivers/platform/x86/lenovo/think-lmi.c
>> @@ -177,6 +177,28 @@ MODULE_PARM_DESC(debug_support, "Enable debug command support");
>>  #define TLMI_CERT_SVC BIT(7) /* Admin Certificate Based */
>>  #define TLMI_CERT_SMC BIT(8) /* System Certificate Based */
>>  
>> +struct tlmi_cert_guids {
>> +	char *thumbprint;
>> +	char *set_bios_setting;
>> +	char *save_bios_setting;
>> +	char *cert_to_password;
>> +	char *clear_bios_cert;
>> +	char *update_bios_cert;
>> +	char *set_bios_cert;
>
> const char
>
yep.

>> +};
>> +
>> +static struct tlmi_cert_guids thinkpad_cert_guid = {
>
> These are not supposed to be altered, right? If so, this should be const 
> then.
>
Weird...I could have sworn I made it a const. I'll fix

>> +	.thumbprint = LENOVO_CERT_THUMBPRINT_GUID,
>> +	.set_bios_setting = LENOVO_SET_BIOS_SETTING_CERT_GUID,
>> +	.save_bios_setting = LENOVO_SAVE_BIOS_SETTING_CERT_GUID,
>> +	.cert_to_password = LENOVO_CERT_TO_PASSWORD_GUID,
>> +	.clear_bios_cert = LENOVO_CLEAR_BIOS_CERT_GUID,
>> +	.update_bios_cert = LENOVO_UPDATE_BIOS_CERT_GUID,
>> +	.set_bios_cert = LENOVO_SET_BIOS_CERT_GUID,
>> +};
>> +
>> +static struct tlmi_cert_guids *cert_guid = &thinkpad_cert_guid;
>
> const here as well. Please also note my comment on placement of this in 
> patch 2.

Ack.

Thanks for the review
Mark