Re: [PATCH v2 04/18] cpufreq: brcmstb-avs-cpufreq: Use __free(put_cpufreq_policy) for policy reference

[Zihuan Zhang]

在 2025/8/29 13:59, Viresh Kumar 写道:
> On 27-08-25, 10:31, Zihuan Zhang wrote:
> > Replace the manual cpufreq_cpu_put() with __free(put_cpufreq_policy)
> > annotation for policy references. This reduces the risk of reference
> > counting mistakes and aligns the code with the latest kernel style.
> >
> > No functional change intended.
> >
> > Signed-off-by: Zihuan Zhang <zhangzihuan@xxxxxxxxxx>
> > ---
> >   drivers/cpufreq/brcmstb-avs-cpufreq.c | 4 +---
> >   1 file changed, 1 insertion(+), 3 deletions(-)
> Applied. Thanks.

Thanks for applying the patch!

I’ve been thinking further — instead of using __free directly, maybe we 
could introduce a small macro wrapper around it to make the release 
scope more controllable and consistent.

Link: 
https://lore.kernel.org/all/6174bcc8-30f5-479b-bac6-f42eb1232b4d@xxxxxxxxxx/

Do you think this would be a better approach, or should we just stick 
with the current use of __free?