Re: [PATCH net-next 1/2] net: pse-pd: pd692x0: Separate configuration parsing from hardware setup
From: Kory Maincent
Date: Fri Aug 29 2025 - 04:26:56 EST
On Thu, 28 Aug 2025 15:12:18 -0700
Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
> On Thu, 28 Aug 2025 10:46:12 +0200 Kory Maincent wrote:
> > > On Fri, 22 Aug 2025 17:37:01 +0200 Kory Maincent wrote:
> [...]
> > >
> > > Leaking manager..
> >
> > I don't think so, as manager is declared like the following it should not.
> > struct pd692x0_manager *manager __free(kfree) = NULL;
>
> Please consult documentation on the user of __free() within networking.
Oh, I didn't know about this net policy.
I didn't follow the maintainer-netdev doc changes. Maybe I should.
Ok, I will add a patch to the series to remove the __free macro.
Regards,
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com