Re: [PATCH] ARM: module: Ensure the override of module_arch_freeing_init()
From: Russell King (Oracle)
Date: Fri Aug 29 2025 - 06:12:18 EST
On Fri, Aug 29, 2025 at 11:06:44AM +0200, Petr Pavlu wrote:
> The function module_arch_freeing_init() defined in arch/arm/kernel/module.c
> is supposed to override a weak function of the same name defined in
> kernel/module/main.c. However, the ARM override is also marked as weak,
> which means that selecting the correct function unnecessarily depends on
> the order in which object files with both functions are passed to the
> linker. Although it happens to be correct at the moment, the proper pattern
> is to make the ARM override a strong definition.
>
> Fixes: cdcb07e45a91 ("ARM: 8975/1: module: fix handling of unwind init sections")
> Signed-off-by: Petr Pavlu <petr.pavlu@xxxxxxxx>
LGTM, please ensure it ends up in the patch system (see signature
below). Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!