Re: [PATCH net-next v4 2/2] net: phy: micrel: Add PTP support for lan8842

[Russell King (Oracle)]

On Fri, Aug 29, 2025 at 08:26:54AM +0200, Horatiu Vultur wrote:
> The 08/28/2025 09:27, Russell King (Oracle) wrote:
> > On Thu, Aug 28, 2025 at 09:34:25AM +0200, Horatiu Vultur wrote:
> > > @@ -457,6 +457,9 @@ struct lan8842_phy_stats {
> > >
> > >  struct lan8842_priv {
> > >       struct lan8842_phy_stats phy_stats;
> > > +     int rev;
> > 
> > Maybe make this a u16 and move it at the end of the struct?
> 
> Yes, I can make it u16 and move it at the end.
> Just for understanding, do you want to move it at the end not to have
> any holes in the struct?

Correct. It makes sense to avoid holes where it doesn't detract from
readability.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!