Re: [PATCH net-next v3 1/2] drivers: net: stmmac: handle start time set in the past for flexible PPS

[Gatien CHEVALLIER]

On 8/28/25 04:31, Jakub Kicinski wrote:
> On Wed, 27 Aug 2025 13:04:58 +0200 Gatien Chevallier wrote:
> > +		curr_time = ns_to_timespec64(ns);
> > +		if (target_ns < ns + PTP_SAFE_TIME_OFFSET_NS) {
> > +			cfg->start = timespec64_add_safe(cfg->start, curr_time);
>
> Is there a strong reason to use timespec64_add_safe()?
> It's not exported to modules:
> ERROR: modpost: "timespec64_add_safe" [drivers/net/ethernet/stmicro/stmmac/stmmac.ko] undefined!

Hello Jakub,

you're absolutely right. I don't know how I did not encounter the build
error while performing some tests, that I'm getting now as well.

The handling of overflows is already done in that function. Either
I can make a patch to export the symbol or handle the computation in the
driver. What do you think is best?

Cheers,
Gatien