Re: [PATCH] watchdog: s3c2410: Add FSD support

[Krzysztof Kozlowski]

On 29/08/2025 16:00, Varada Pavani wrote:
> +
>  static const struct of_device_id s3c2410_wdt_match[] = {
>  	{ .compatible = "google,gs101-wdt",
>  	  .data = &drv_data_gs101_cl0 },
> @@ -352,6 +380,8 @@ static const struct of_device_id s3c2410_wdt_match[] = {
>  	  .data = &drv_data_exynosautov9_cl0 },
>  	{ .compatible = "samsung,exynosautov920-wdt",
>  	  .data = &drv_data_exynosautov920_cl0 },
> +	{ .compatible = "tesla,fsd-wdt",

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.


Best regards,
Krzysztof