Re: [PATCH v2 1/2] dt-bindings: phy: add support for NXPs TJA1145 CAN transceiver

[Krzysztof Kozlowski]

On 29/08/2025 15:12, Krzysztof Kozlowski wrote:
> On 29/08/2025 11:19, Dimitri Fedrau via B4 Relay wrote:
>> From: Dimitri Fedrau <dimitri.fedrau@xxxxxxxxxxxx>
>>
>> Adding documentation for NXPs TJA1145 CAN transceiver.
> 
> Pity you did not include resolution of discussions about directory and
> can phy bindings here. You have entire commit msg for that, but instead
> it is a copy paste of subject.
> 
>>
>> Signed-off-by: Dimitri Fedrau <dimitri.fedrau@xxxxxxxxxxxx>
>> ---
>>  .../devicetree/bindings/phy/nxp,tja1145-can.yaml   | 79 ++++++++++++++++++++++
>>  1 file changed, 79 insertions(+)
> 
>>
> 
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

And un-reviewed, I missed messed example and this was never tested.

Sending untested code only makes us grumpy.

Best regards,
Krzysztof