Re: [PATCH v2 1/9] spi: spi-fsl-lpspi: Fix transmissions when using CONT
From: Frank Li
Date: Fri Aug 29 2025 - 10:27:40 EST
On Fri, Aug 29, 2025 at 01:38:15PM +0200, Mark Brown wrote:
> On Thu, Aug 28, 2025 at 11:14:40AM +0100, James Clark wrote:
> > From: Larisa Grigore <larisa.grigore@xxxxxxx>
> >
> > Commit 6a130448498c ("spi: lpspi: Fix wrong transmission when don't use
> > CONT") breaks transmissions when CONT is used. The TDIE interrupt should
> > not be disabled in all cases. If CONT is used and the TX transfer is not
> > yet completed yet, but the interrupt handler is called because there are
> > characters to be received, TDIE is replaced with FCIE. When the transfer
> > is finally completed, SR_TDF is set but the interrupt handler isn't
> > called again.
>
> Frank, you've reviewed the whole series except for this patch - is there
> some issue with it?
I need read spec and code to understand code logic. It should be correct.
Reviewed-by: Frank Li <Frank.Li@xxxxxxx>