Re: [PATCH net-next v5 1/2] net: phy: micrel: Introduce function __lan8814_ptp_probe_once

From: Kory Maincent
Date: Fri Aug 29 2025 - 10:34:33 EST


On Fri, 29 Aug 2025 15:48:35 +0200
Horatiu Vultur <horatiu.vultur@xxxxxxxxxxxxx> wrote:

> Introduce the function __lan8814_ptp_probe_once as this function will be
> used also by lan8842 driver. This change doesn't have any functional
> changes.

It would have been nice to add the fact that the lan8842 has a different number
GPIO in the commit message. It would have explained more the why.

Reviewed-by: Kory Maincent <kory.maincent@xxxxxxxxxxx>

Thank you!

--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com