Re: [PATCH] irqchip: Use int type to store negative error codes
From: Marc Zyngier
Date: Fri Aug 29 2025 - 11:04:46 EST
On Fri, 29 Aug 2025 14:20:19 +0100,
Qianfeng Rong <rongqianfeng@xxxxxxxx> wrote:
>
> Change the 'ret' variable from unsigned int to int to store negative error
> codes or zero returned by other functions.
>
> Storing the negative error codes in unsigned type, doesn't cause an issue
> at runtime but it's ugly. Additionally, assigning negative error codes to
> unsigned type may trigger a GCC warning when the -Wsign-conversion flag is
> enabled.
>
> Signed-off-by: Qianfeng Rong <rongqianfeng@xxxxxxxx>
For the GICv3 code:
Acked-by: Marc Zyngier <maz@xxxxxxxxxx>
M.
--
Without deviation from the norm, progress is not possible.