Re: [PATCH v3 3/4] iio: adc: ad7124: add external clock support

[Andy Shevchenko]

On Fri, Aug 29, 2025 at 12:55 AM David Lechner <dlechner@xxxxxxxxxxxx> wrote:
>
> Add support for an external clock source to the AD7124 ADC driver.
>
> Previously, the driver only supported using the internal clock and had
> bad devicetree bindings that used a fake clock to essentially select
> the power mode. This is preserved for backwards compatibility.
>
> If the clock is not named "mclk", then we know that the devicetree is
> using the correct bindings and we can configure the chip to use an
> external clock source rather than internal.
>
> Also drop a redundant comment when configuring the register fields
> instead of adding more.

...

> +                       if (clk_hz > MEGA) {

I read your answer, but maybe I missed something?  Can we use (1 *
HZ_PER_MHZ) here?

> +                               clk_sel = AD7124_ADC_CONTROL_CLK_SEL_EXT_DIV4;
> +                               st->clk_hz = clk_hz / 4;
> +                       } else {
> +                               clk_sel = AD7124_ADC_CONTROL_CLK_SEL_EXT;
> +                               st->clk_hz = clk_hz;
> +                       }


-- 
With Best Regards,
Andy Shevchenko