Re: [PATCH v7 5/6] rust: pci: use pci::Vendor instead of bindings::PCI_VENDOR_ID_*

[John Hubbard]

On 8/29/25 2:46 PM, Danilo Krummrich wrote:
> On 8/29/25 11:38 PM, John Hubbard wrote:
>> On 8/28/25 6:59 AM, Danilo Krummrich wrote:
>>> On 8/28/25 3:25 PM, Alexandre Courbot wrote:
>>>> On Wed Aug 27, 2025 at 8:12 AM JST, John Hubbard wrote:
>>>> <snip>
>>> makes a little more sense if this patch simply introduces the example as an
>>> example for vendor_id() itself.
>>>
>>> I think struct Vendor does not necessarily need an example by itself.
>>
>> I'm not quite sure if you are asking for a change to this patch? The
>> example already exercises .vendor_id(), so...?
> 
> Yes, I think the example above should be on the vendor_id() method rather than
> on the Vendor struct and should be introduced by this patch.

ohhh, so located directly above it. I finally get it. haha. I'll do that, thanks. :)


thanks,
-- 
John Hubbard