Re: [PATCH 1/2] iio: adc: Add driver for Marvell 88PM886 PMIC ADC

[Andy Shevchenko]

On Sat, Aug 30, 2025 at 7:37 AM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Fri, Aug 29, 2025 at 2:41 AM David Lechner <dlechner@xxxxxxxxxxxx> wrote:
> > On 8/28/25 5:17 PM, Duje Mihanović wrote:

...


> > > +     ret = regmap_bulk_read(*map, regs[chan], buf, 2);

On top, please drop a double pointer and use map directly. That's
already a pointer, what's the issue with it to begin with?

> sizeof()
>
> > > +
>
> Redundant blank line.
>
> > > +     if (ret)
> > > +             return ret;

-- 
With Best Regards,
Andy Shevchenko