Re: [PATCH v3 2/4] dt-bindings: leds: commonize leds property
From: Konrad Dybcio
Date: Mon Sep 08 2025 - 03:20:51 EST
On 9/8/25 1:18 AM, Aleksandrs Vinarskis wrote:
> A number of existing schemas use 'leds' property to provide
> phandle-array of LED(s) to the consumer. Additionally, with the
> upcoming privacy-led support in device-tree, v4l2 subnode could be a
> LED consumer, meaning that all camera sensors should support 'leds'
> and 'led-names' property via common 'video-interface-devices.yaml'.
>
> To avoid dublication, commonize 'leds' property from existing schemas
> to newly introduced 'led-consumer.yaml'.
>
> Signed-off-by: Aleksandrs Vinarskis <alex@xxxxxxxxxxxxx>
> ---
[...]
>
> + leds:
> + minItems: 1
> + maxItems: 1
My brain compiler suggests this will throw a warning (minItems should
be redundant in this case)
> +
> + led-names:
> + enum:
> + - privacy-led
Nit: "privacy" makes more sense without the suffix, as we inherently
know this is supposed to be an LED
Konrad