Re: [PATCH v5 04/12] ltp/fsx.c: Add atomic writes support to fsx

From: John Garry
Date: Mon Sep 08 2025 - 03:54:31 EST


On 05/09/2025 17:29, Ojaswin Mujoo wrote:
+
+/*
+ * Round down n to nearest power of 2.
+ * If n is already a power of 2, return n;
+ */
+static int rounddown_pow_of_2(int n) {
+ int i = 0;
+
+ if (is_power_of_2(n))
+ return n;
+
+ for (; (1 << i) < n; i++);
+
+ return 1 << (i - 1);
Is this the neatest way to do this?
Well it is a straigforward o(logn) way. Do you have something else in
mind?

check what the kernel does is always a good place to start...

Thanks