Re: [PATCH] sh: mach-rsk: rsk7203: use static device properties for LEDs and GPIO buttons

From: Dmitry Torokhov

Date: Mon Sep 08 2025 - 08:28:09 EST


On Wed, Aug 13, 2025 at 03:50:09PM +0300, Andy Shevchenko wrote:
> On Mon, Aug 11, 2025 at 03:44:57PM -0700, Dmitry Torokhov wrote:
> > Convert the board to use static device properties instead of platform
> > data to describe LEDs and GPIO-connected buttons on the board, so
> > that support for platform data can be removed from gpio-keys and other
> > drivers, unifying their behavior.
>
> ...
>
> > --- a/arch/sh/boards/mach-rsk/devices-rsk7203.c
> > +++ b/arch/sh/boards/mach-rsk/devices-rsk7203.c
>
> > #include <linux/gpio.h>
>
> Do we still need this one?

Yes, at least this one still uses gpio_request() for configuring some
GPIOs, so we need to keep it at least for now.

>
> Ditto for the rest similar cases.

I'll review them to make sure they are still needed.

Thanks.

--
Dmitry