Re: [PATCH v5 15/19] kasan: x86: Apply multishot to the inline report handler

[Maciej Wieczor-Retman]

On 2025-09-06 at 19:19:06 +0200, Andrey Konovalov wrote:
>On Mon, Aug 25, 2025 at 10:30 PM Maciej Wieczor-Retman
><maciej.wieczor-retman@xxxxxxxxx> wrote:
>>
>> KASAN by default reports only one tag mismatch and based on other
>> command line parameters either keeps going or panics. The multishot
>> mechanism - enabled either through a command line parameter or by inline
>> enable/disable function calls - lifts that restriction and allows an
>> infinite number of tag mismatch reports to be shown.
>>
>> Inline KASAN uses the INT3 instruction to pass metadata to the report
>> handling function. Currently the "recover" field in that metadata is
>> broken in the compiler layer and causes every inline tag mismatch to
>> panic the kernel.
>>
>> Check the multishot state in the KASAN hook called inside the INT3
>> handling function.
>>
>> Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@xxxxxxxxx>
>> ---
>> Changelog v4:
>> - Add this patch to the series.
>>
>>  arch/x86/mm/kasan_inline.c | 3 +++
>>  include/linux/kasan.h      | 3 +++
>>  mm/kasan/report.c          | 8 +++++++-
>>  3 files changed, 13 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/mm/kasan_inline.c b/arch/x86/mm/kasan_inline.c
>> index 9f85dfd1c38b..f837caf32e6c 100644
>> --- a/arch/x86/mm/kasan_inline.c
>> +++ b/arch/x86/mm/kasan_inline.c
>> @@ -17,6 +17,9 @@ bool kasan_inline_handler(struct pt_regs *regs)
>>         if (!kasan_report((void *)addr, size, write, pc))
>>                 return false;
>>
>> +       if (kasan_multi_shot_enabled())
>> +               return true;
>
>It's odd this this is required on x86 but not on arm64, see my comment
>on the patch that adds kasan_inline_handler().
>

I think this is needed if we want to keep the kasan_inline_recover below.
Because without this patch, kasan_report() will report a mismatch, an then die()
will be called. So the multishot gets ignored.

I'll check what happens on arm64 when a mismatch happens with inline mode +
multishot.

>
>> +
>>         kasan_inline_recover(recover, "Oops - KASAN", regs, metadata, die);
>>
>>         return true;
>> diff --git a/include/linux/kasan.h b/include/linux/kasan.h
>> index 8691ad870f3b..7a2527794549 100644
>> --- a/include/linux/kasan.h
>> +++ b/include/linux/kasan.h
>> @@ -663,7 +663,10 @@ void kasan_non_canonical_hook(unsigned long addr);
>>  static inline void kasan_non_canonical_hook(unsigned long addr) { }
>>  #endif /* CONFIG_KASAN_GENERIC || CONFIG_KASAN_SW_TAGS */
>>
>> +bool kasan_multi_shot_enabled(void);
>> +
>>  #ifdef CONFIG_KASAN_SW_TAGS
>> +
>>  /*
>>   * The instrumentation allows to control whether we can proceed after
>>   * a crash was detected. This is done by passing the -recover flag to
>> diff --git a/mm/kasan/report.c b/mm/kasan/report.c
>> index 50d487a0687a..9e830639e1b2 100644
>> --- a/mm/kasan/report.c
>> +++ b/mm/kasan/report.c
>> @@ -121,6 +121,12 @@ static void report_suppress_stop(void)
>>  #endif
>>  }
>>
>> +bool kasan_multi_shot_enabled(void)
>> +{
>> +       return test_bit(KASAN_BIT_MULTI_SHOT, &kasan_flags);
>> +}
>> +EXPORT_SYMBOL(kasan_multi_shot_enabled);
>> +
>>  /*
>>   * Used to avoid reporting more than one KASAN bug unless kasan_multi_shot
>>   * is enabled. Note that KASAN tests effectively enable kasan_multi_shot
>> @@ -128,7 +134,7 @@ static void report_suppress_stop(void)
>>   */
>>  static bool report_enabled(void)
>>  {
>> -       if (test_bit(KASAN_BIT_MULTI_SHOT, &kasan_flags))
>> +       if (kasan_multi_shot_enabled())
>>                 return true;
>>         return !test_and_set_bit(KASAN_BIT_REPORTED, &kasan_flags);
>>  }
>> --
>> 2.50.1
>>

-- 
Kind regards
Maciej Wieczór-Retman