Re: [PATCH] net: atlantic: make RX page order tunable via module param

[Andrew Lunn]

> +static unsigned int rxpageorder = AQ_CFG_RX_PAGEORDER;
> +module_param_named(rxpageorder, rxpageorder, uint, 0644);
> +MODULE_PARM_DESC(rxpageorder, "RX page order");

Sorry, but netdev does not like module params. They are a bad API to
use. Please find a different way to do this.

Also, there is a comment:

	/* Only order-2 is allowed if XDP is enabled */
	if (READ_ONCE(self->xdp_prog)) {

You need to ensure this assumption is not broken.

	Andrew