Re: [PATCH 0/3] samples/damon: fix boot time enable handling fixup merge mistakes

[SeongJae Park]

On Mon, 8 Sep 2025 19:35:48 -0700 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Mon,  8 Sep 2025 19:22:35 -0700 SeongJae Park <sj@xxxxxxxxxx> wrote:
> 
> > First three patches of the patch series "mm/damon: fix misc bugs in
> > DAMON modules" [1] was trying to fix boot time DAMON sample modules
> > enabling issues by avoiding starting DAMON before the module
> > initialization phase.  However, probably by a mistake during a merge,
> > only half of the change is merged, and the part for avoiding the
> > starting of DAMON before the module initialized is missed.  So the
> > problem is not solved.  Fix those.
> > 
> > Note that the broken commits are merged into 6.17-rc1, but also
> > backported to relevant stable kernels.  So this series also need to be
> > merged into the stable kernels.  Hence Cc-ing stable@.
> 
> That's unfortunate, but the about doesn't actually tell us what this
> series does.  

Good point.  The issue is that the sample modules can crash if those are
enabled at boot time before DAMON is initialized, via kernel command line.

Would you prefer me sending another version of this patch series with an
elaborated cover letter?

> 
> > [1] https://lore.kernel.org/20250706193207.39810-1-sj@xxxxxxxxxx
> 
> Presumably it's in there somewhere?

You're right.  Both the cover letter and the individual fix patches (first
three of the series) describes the issue and origin broken commit.

Please let me know if there is anything I can help for this patch series from
my side :)


Thanks,
SJ