Re: [PATCH] s390/nmi: Simplify return statement in nmi_registers_valid()

From: Thorsten Blum
Date: Tue Sep 09 2025 - 04:09:25 EST


On 9. Sep 2025, at 08:25, Heiko Carstens wrote:
> On Mon, Sep 08, 2025 at 06:52:11PM +0200, Alexander Gordeev wrote:
>>
>> This change does not make the whole function readability better.
>
> It actually would decrease readability since every if-statement tells
> you one condition when registers are not valid. Negating the last one
> makes this harder to understand.

Ah my bad, that makes sense. I didn't take the whole function into
account.

Thanks,
Thorsten