Re: [PATCH V3 3/5] media: platform: ti: Switch to EXPORT_SYMBOL_GPL()

From: Krzysztof Kozlowski
Date: Tue Sep 09 2025 - 04:24:35 EST


On 09/09/2025 10:07, Yemike Abhilash Chandra wrote:
> struct vpdma_dtd *dtd = list->buf.addr;
> dma_addr_t write_desc_addr;
> @@ -597,7 +598,7 @@ void vpdma_update_dma_addr(struct vpdma_data *vpdma,
>
> dump_dtd(dtd);
> }
> -EXPORT_SYMBOL(vpdma_update_dma_addr);
> +EXPORT_SYMBOL_GPL(vpdma_update_dma_addr);

Don't add incorrect code to fix it immediately. Claiming that "you just
revert" is irrelevant here - we are not interested in the revert. Revert
or not, you add new code to the kernel, so that code must be correct.

if you reverted a commit, which was introducing a security bug, your
revert would bring that security bug and you find it okay?

No, NAK.

Best regards,
Krzysztof