RE: [PATCH 04/11] phy: renesas: Add Renesas RZ/G3E USB3.0 PHY driver

[Biju Das]

Hi Vinod,

Thanks for the feedback.

> -----Original Message-----
> From: Vinod Koul <vkoul@xxxxxxxxxx>
> Sent: 01 September 2025 17:28
> Subject: Re: [PATCH 04/11] phy: renesas: Add Renesas RZ/G3E USB3.0 PHY driver
> 
> On 20-08-25, 18:17, Biju wrote:
> 
> > +static int rzg3e_phy_usb3test_phy_init(void __iomem *base) {
> > +	int ret;
> > +	u32 val;
> > +
> > +	writel(0x00000100, base + USB3_TEST_CREGCTRL);
> > +	writel(0x00000303, base + USB3_TEST_RSTCTRL);
> > +	fsleep(20);
> > +
> > +	writel(0x00000004, base + USB3_TEST_CLKCTRL);
> > +	writel(0x0000000d, base + USB3_TEST_LANECONFIG0);
> > +	writel(0x00000301, base + USB3_TEST_RSTCTRL);
> 
> Magic numbers...?

OK will add macros to make it meaningful.

Cheers,
Biju