Re: [PATCH v23] pwm: airoha: Add support for EN7581 SoC

[Andy Shevchenko]

On Tue, Sep 09, 2025 at 01:51:11PM +0200, Christian Marangi wrote:
> On Tue, Sep 09, 2025 at 02:20:43PM +0300, Andy Shevchenko wrote:
> > On Mon, Sep 08, 2025 at 08:48:38PM +0200, Christian Marangi wrote:
> > > On Fri, Aug 01, 2025 at 11:15:41AM +0200, Uwe Kleine-König wrote:
> > > > On Tue, Jul 08, 2025 at 04:50:52PM +0200, Christian Marangi wrote:

> > > > > +	 * Period goes at 4ns step, normalize it to check if we can
> > > > 
> > > > 4 ms or 4 ns?
> > > 
> > > 4ms you are right
> > 
> > One small but important side note (to Uwe as well, however he seems
> > follows what I am about to say). Recently I discovered a nice wrap-up [1]
> > on the writing values with units. And I think we should try to follow it
> > (at bare minimum to be consistent with chosen — Journalism vs. Scientific —
> >  style).
> > 
> > [1]: https://poynton.ca/notes/units/
> 
> Just to be more precise, on comments we should use NUMBER SPACE UNIT? I
> think for variables it's problematic.

Of course the note only about documentation and comments, not about the code :-)
And yes, $NUMBER space $UNIT (personally I prefer the Scientific way).

-- 
With Best Regards,
Andy Shevchenko