Re: [PATCH 1/2] dt-bindings: input: pm8941-pwrkey: Document wakeup-source property

[Krzysztof Kozlowski]

On 09/09/2025 15:23, Luca Weiss wrote:
> The 'resin' keys (usually connected to a volume-down button) are
> generally not supposed to wake up the device from suspend, so explicitly
> document a wakeup-source property to enable this wakeup behavior.
> 
> For 'pwrkey' the default stays that pressing the button does wake up the
> device from suspend.
> 
> Signed-off-by: Luca Weiss <luca@xxxxxxxxxxxx>
> ---
>  .../bindings/input/qcom,pm8941-pwrkey.yaml          | 21 ++++++++++++++++++---
>  1 file changed, 18 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.yaml b/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.yaml
> index 62314a5fdce59bb00d1e8b86d6a29a091128aa50..62a08e675ef9511e0ae9ed9fbab5694ab7242c35 100644
> --- a/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.yaml
> +++ b/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.yaml
> @@ -10,9 +10,6 @@ maintainers:
>    - Courtney Cavin <courtney.cavin@xxxxxxxxxxxxxx>
>    - Vinod Koul <vkoul@xxxxxxxxxx>
>  
> -allOf:
> -  - $ref: input.yaml#
> -
>  properties:
>    compatible:
>      enum:
> @@ -36,6 +33,11 @@ properties:
>             pin should be configured for pull up.
>      $ref: /schemas/types.yaml#/definitions/flag
>  
> +  wakeup-source:
> +    description: |
> +           Button can wake-up the system. Only applicable for 'resin',
> +           'pwrkey' always wakes the system by default.


I'll fix existing code, so don't repeat that style.


Best regards,
Krzysztof