Re: [PATCH 2/7] can: m_can: m_can_rx_handler(): only handle active interrupts

From: Marc Kleine-Budde

Date: Tue Sep 09 2025 - 10:11:18 EST


On 19.08.2025 10:29:09, Markus Schneider-Pargmann wrote:
> On Tue Aug 12, 2025 at 7:36 PM CEST, Marc Kleine-Budde wrote:
> > Among other things, the M_CAN IP core has an Interrupt Register (IR)
> > and an Interrupt Enable (IE) register. An interrupt is triggered if at
> > least 1 bit is set in the bitwise and of IR and IE.
> >
> > Depending on the configuration not all interrupts are enabled in the
> > IE register. However the m_can_rx_handler() IRQ handler looks at all
> > interrupts not just the enabled ones. This may lead to handling of not
> > activated interrupts.
>
> But isn't that happening for m_can_interrupt_handler() in general then?

Yes, I'll add it to the m_can_interrupt_handler(), too.

Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |

Attachment: signature.asc
Description: PGP signature