RE: [PATCH v6 net-next 1/6] net: fec: use a member variable for maximum buffer size

[Shenwei Wang]

> -----Original Message-----
> From: Wei Fang <wei.fang@xxxxxxx>
> Sent: Monday, September 8, 2025 9:12 PM
> To: Shenwei Wang <shenwei.wang@xxxxxxx>
> Cc: Clark Wang <xiaoning.wang@xxxxxxx>; Stanislav Fomichev
> <sdf@xxxxxxxxxxx>; imx@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>; Andrew Lunn
> <andrew@xxxxxxx>; Frank Li <frank.li@xxxxxxx>; Andrew Lunn
> <andrew+netdev@xxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric
> Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo
> Abeni <pabeni@xxxxxxxxxx>; Alexei Starovoitov <ast@xxxxxxxxxx>; Daniel
> Borkmann <daniel@xxxxxxxxxxxxx>; Jesper Dangaard Brouer
> <hawk@xxxxxxxxxx>; John Fastabend <john.fastabend@xxxxxxxxx>
> Subject: RE: [PATCH v6 net-next 1/6] net: fec: use a member variable for
> maximum buffer size
> 
> > @@ -253,9 +253,7 @@ MODULE_PARM_DESC(macaddr, "FEC Ethernet MAC
> > address");  #if defined(CONFIG_M523x) || defined(CONFIG_M527x) ||
> > defined(CONFIG_M528x) || \
> >      defined(CONFIG_M520x) || defined(CONFIG_M532x) ||
> > defined(CONFIG_ARM) || \
> >      defined(CONFIG_ARM64)
> > -#define	OPT_FRAME_SIZE	(PKT_MAXBUF_SIZE << 16)
> > -#else
> > -#define	OPT_FRAME_SIZE	0
> > +#define	OPT_ARCH_HAS_MAX_FL
> 
> In the fec driver, I noticed that the expression "#if defined (CONFIG_M523x) ||
> defined(CONFIG_M527x) || ..." is used in four different places. I think we could
> add a separate patch to define a new macro to replace these occurrences. This
> new macro should be more generic than OPT_ARCH_HAS_MAX_FL.
> 

That is outside the scope of this patch and should be addressed in a follow-up 
cleanup patch later.

Thanks,
Shenwei

> >  #endif
> >
> >  /* FEC MII MMFR bits definition */