Re: [PATCH] staging: gpib: Declare processor directive as CONFIG_TNT4882

[Greg Kroah-Hartman]

On Tue, Sep 09, 2025 at 07:56:07PM +0530, GOPI JEGANATHAN wrote:
> Hi Greg
> 
> I just saw the warning message in Checkpatch.pl file. It's says #if 0 is
> something wrong so I just change the processor directives properly using
> #ifdef CONFIG_TNT4882, Is that change is wrong!?

#if 0 is a way to comment out code, you just enabled that code to now be
present.  That's probably not the correct thing for this driver, right?
The whole thing is already using CONFIG_TNT4882, so declaring it again
would be the same as just removing the #if 0 line.

In short, only change this type of thing either by removing the code
entirely, or figuring out why it's still present and then fixing it up
to actually be used and remove the #if 0 lines.

thanks,

greg k-h