Re: [PATCH 4/5] drm/msm/registers: Generate _HI/LO builders for reg64
From: Dmitry Baryshkov
Date: Tue Sep 09 2025 - 11:02:22 EST
On Mon, Sep 08, 2025 at 12:30:07PM -0700, Rob Clark wrote:
> The upstream mesa copy of the GPU regs has shifted more things to reg64
> instead of seperate 32b HI/LO reg32's. This works better with the "new-
> style" c++ builders that mesa has been migrating to for a6xx+ (to better
> handle register shuffling between gens), but it leaves the C builders
> with missing _HI/LO builders.
>
> So handle the special case of reg64, automatically generating the
> missing _HI/LO builders.
>
> Signed-off-by: Rob Clark <robin.clark@xxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/msm/registers/gen_header.py | 7 +++++++
> 1 file changed, 7 insertions(+)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
--
With best wishes
Dmitry