Re: [PATCH 3/3] mm: zpdesc: minor naming and comment corrections
From: Johannes Weiner
Date: Tue Sep 09 2025 - 11:11:49 EST
On Fri, Sep 05, 2025 at 07:05:22PM +0000, Yosry Ahmed wrote:
> On Fri, Aug 29, 2025 at 05:15:28PM +0100, Johannes Weiner wrote:
> > zpdesc is the page descriptor used by the zsmalloc backend allocator,
> > which in turn is used by zswap and zram. The zpool layer is gone.
> >
> > Signed-off-by: Johannes Weiner <hannes@xxxxxxxxxxx>
> > ---
>
> Why not rename zpdesc to zsdesc or zdesc while we're at it? It's a lot
> of noise but it's just this file and zsmalloc.c IIUC. Up to you.
I'm kind of fine with zpdesc and not sure the other names are this
much better to warrant the churn. So if you don't mind, I'd just leave
it alone for now.
> If it's just the comment changes I would squash it into the second
> patch, but not a big deal. Either way:
>
> Acked-by: Yosry Ahmed <yosry.ahmed@xxxxxxxxx>
Thanks for your review!