Re: [PATCH v5 2/2] drm: bridge: cdns-mhdp8546: Add support for DSC and FEC

[Dmitry Baryshkov]

On Mon, Sep 15, 2025 at 02:06:58PM +0300, Dmitry Baryshkov wrote:
> On Mon, Sep 15, 2025 at 04:00:41PM +0530, Harikrishna Shenoy wrote:
> > From: Swapnil Jakhade <sjakhade@xxxxxxxxxxx>
> > 
> > Enable support for Display Stream Compression (DSC) in independent
> > mode with a single stream, along with Forward Error Correction (FEC)
> > in the Cadence MHDP8546 DisplayPort controller driver.
> > 
> > FEC is required when DSC is enabled to ensure reliable transmission
> > of the compressed stream.
> > 
> > Signed-off-by: Swapnil Jakhade <sjakhade@xxxxxxxxxxx>
> > Signed-off-by: Harikrishna Shenoy <h-shenoy@xxxxxx>
> > ---
> >  drivers/gpu/drm/bridge/cadence/Makefile       |   2 +-
> >  .../drm/bridge/cadence/cdns-mhdp8546-core.c   | 367 ++++++++-
> >  .../drm/bridge/cadence/cdns-mhdp8546-core.h   |  68 ++
> >  .../drm/bridge/cadence/cdns-mhdp8546-dsc.c    | 695 ++++++++++++++++++
> >  .../drm/bridge/cadence/cdns-mhdp8546-dsc.h    | 285 +++++++
> >  5 files changed, 1392 insertions(+), 25 deletions(-)
> >  create mode 100644 drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-dsc.c
> >  create mode 100644 drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-dsc.h
> > 
> > +		goto err;
> > +	}
> > +
> > +	if (ret > 0)
> > +		return 0;
> > +err:
> > +	return ret;
> > +}
> 
> Consider extracting a common helper and using it here and in the Intel
> DP driver. Also please use new DPCD helpers which return 0 instead of
> size.

For the reference, some time ago one of my colleagues implemented DP DSC
support for the drm/msm driver. It didn't go in for multiple reasons,
but feel free to use it as an inspiration for possible generic helpers.
See https://patchwork.freedesktop.org/series/113240/


-- 
With best wishes
Dmitry