Re: [External] : Re: [PATCH] PCI: plda: Remove the use of dev_err_probe()

[ALOK TIWARI]

Hi Mani,

On 9/8/2025 3:43 PM, Manivannan Sadhasivam wrote:
> On Wed, Aug 20, 2025 at 04:52:00PM GMT, Xichao Zhao wrote:
> > The dev_err_probe() doesn't do anything when error is '-ENOMEM'.
> > Therefore, remove the useless call to dev_err_probe(), and just
> > return the value instead.
>
> Change is fine as it is. But I think devm_pci_alloc_host_bridge() should return
> the actual error pointer instead of NULL and let the callers guess the errno.
>
> Callers are using both -ENOMEM and -ENODEV, both of then will mask the actual
> errno that caused the failure.
>
> Cleanup task for someone interested :)
>
> - Mani

Did you really intend to do that,
Should that be an RFC (for cleanup task) patch ?

Thanks,
Alok