Re: [PATCH net-next] net: dlink: count dropped packets on skb allocation failure

From: Yeounsu Moon

Date: Fri Sep 12 2025 - 05:27:23 EST


On Fri Sep 12, 2025 at 2:02 AM KST, Simon Horman wrote:
> Although new users of dev->stats are discoraged (see ndetdevice.h).
> That is not the case here, as the driver already uses dev-stats.
> So I believe this is change is good.

Thank you for pointing that out! I also plan to rework statistics code
to rtnl-based statistics. However, that change affects a large amount
of code, so I'd like to introduce it gradually and gracefully.

>
>> printk (KERN_INFO
>> "%s: receive_packet: "
>> "Unable to re-allocate Rx skbuff.#%d\n",
>
> Reviewed-by: Simon Horman <horms@xxxxxxxxxx>

Thank you again for reviewing my patch, Simon :)

Yeounsu Moon