Re: [PATCH 1/3] Compiler Attributes: Add __assume macro
From: Miguel Ojeda
Date: Thu Sep 11 2025 - 15:04:49 EST
On Thu, Sep 11, 2025 at 8:44 PM Nathan Chancellor <nathan@xxxxxxxxxx> wrote:
>
> I do not think anyone really owns compiler_types.h so unless Miguel has
> any objections from the compiler attributes perspective, I think you can
> just take this via the s390 tree with the other two changes.
No objections from me, and thanks for spotting the OpenMP thing above.
I would say, though, that this is a fairly general and subtle tool to
have around, so it would be nice to have others chime in. In other
words, do we want to start using `assume`s? Should we constrain its
use a bit, e.g. say its use should really be justified etc.? (In the
Rust side, a tool like this would require a SAFETY comment on top with
a justification, which may give a developer pause).
Thanks!
Cheers,
Miguel