Re: [PATCH v14 0/4] leds: add new LED driver for TI LP5812

[Greg KH]

On Sun, Sep 07, 2025 at 11:09:40PM +0700, Nam Tran wrote:
> This patch series adds initial support for the TI LP5812,
> a 4x3 matrix RGB LED driver with autonomous engine control.
> This version provides a minimal, clean implementation focused
> on core functionality only. The goal is to upstream a solid
> foundation, with the expectation that additional features can
> be added incrementally in future patches.
> 
> The driver integrates with the LED multicolor framework and
> supports a set of basic sysfs interfaces for LED control and
> chip management.
> 
> Signed-off-by: Nam Tran <trannamatk@xxxxxxxxx>

The sysfs api is really odd here.  WHy not do the same thing as this
other controller recently submitted does:
	https://lore.kernel.org/r/20250911-v6-14-topic-ti-lp5860-v3-0-390738ef9d71@xxxxxxxxxxxxxx

but better yet, why does this need to be a kernel driver at all?  Why
can't you just control this directly from userspace with a program
there?

For USB, we generally do not allow these types of crazy apis to be added
to the kernel when controlling the device can be done from userspace.  I
think the same thing can happen here too, right?

thanks,

greg k-h