Re: [RFC PATCH v3 05/10] sched/fair: Don't consider paravirt CPUs for wakeup and load balance

From: K Prateek Nayak

Date: Thu Sep 11 2025 - 12:55:19 EST


Hello Shrikanth,

On 9/11/2025 9:26 PM, Shrikanth Hegde wrote:
>>> +check_new_cpu:
>>> +    if (is_cpu_paravirt(new_cpu))
>>> +        return cpu;
>>> +    else
>>
>> nit. redundant else.
>>
>
> Do you mean "is_cpu_paravirt(new_cpu) ? cpu; new_cpu"

Sorry for the confusion! I meant we can have:

if (is_cpu_paravirt(new_cpu))
return cpu;

return new_cpu;

Since we return from the if clause, we don't need to specify else.

--
Thanks and Regards,
Prateek