Re: [PATCH] sched: fair: drop useless cpumask_empty() in find_energy_efficient_cpu()

From: Markus Elfring

Date: Thu Sep 11 2025 - 10:00:54 EST


> cpumask_empty() call is O(N) and useless, because the previous
> cpumask_and() returns false for empty 'cpus'.

It seems to be more helpful to reuse a return value from a previous function call.
How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17-rc5#n94

Regards,
Markus