Re: [patch V4 33/36] s390: Use generic TIF bits
From: Sven Schnelle
Date: Thu Sep 11 2025 - 05:12:21 EST
Thomas Gleixner <tglx@xxxxxxxxxxxxx> writes:
> No point in defining generic items and the upcoming RSEQ optimizations are
> only available with this _and_ the generic entry infrastructure, which is
> already used by s390. So no further action required here.
>
> This leaves a comment about the AUDIT/TRACE/SECCOMP bits which are handled
> by SYSCALL_WORK in the generic code, so they seem redundant, but that's a
> problem for the s390 wizards to think about.
>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Heiko Carstens <hca@xxxxxxxxxxxxx>
> Cc: Christian Borntraeger <borntraeger@xxxxxxxxxxxxx>
> Cc: Sven Schnelle <svens@xxxxxxxxxxxxx>
>
> --- a/arch/s390/include/asm/thread_info.h
> +++ b/arch/s390/include/asm/thread_info.h
> @@ -56,43 +56,35 @@ void arch_setup_new_exec(void);
> [..]
> +/* These could move over to SYSCALL_WORK bits, no? */
> #define TIF_SYSCALL_TRACE 24 /* syscall trace active */
> #define TIF_SYSCALL_AUDIT 25 /* syscall auditing active */
> #define TIF_SECCOMP 26 /* secure computing */
> #define TIF_SYSCALL_TRACEPOINT 27 /* syscall tracepoint instrumentation */
Looks like these flags are a leftover of the conversion to generic
entry and are no longer used. I'll send a patch on top of your patchset
which remove them.
Thanks!
Sven