Re: [PATCH v2 1/2] ALSA: compress: add raw opus codec define and opus decoder structs

[Takashi Iwai]

On Tue, 16 Sep 2025 06:20:31 +0200,
Alexey Klimov wrote:
> 
> Hi Takashi,
> 
> On Wed Sep 10, 2025 at 10:17 AM BST, Takashi Iwai wrote:
> > On Wed, 10 Sep 2025 10:11:41 +0200,
> > Alexey Klimov wrote:
> >> +struct snd_dec_opus {
> >> +	union {
> >> +		struct {
> >> +			__u8 minor:4;
> >> +			__u8 major:4;
> >> +		} __attribute__((packed)) fields;
> >
> > Bit fields aren't really good for ABI definition, as it's not well
> > defined.  I'd rather leave it as a u8.  If any, you can provide a
> > bitmask definition or a macro to retrieve the version numbers.
> 
> Okay.
> 
> > Also, don't forget to bump the API protocol number.
> > It's been already increased to 0.4.0 for 64bit tstamp support, and
> > yours need to increase one more.
> 
> Can you please advice if minor version should be increased i.e. it
> should become 0.4.1? Or should it 0.5.0?

0.4.1 should suffice in this case, I believe.

> > (That is, please make sure to create patches based on linux-next, or
> >  for-next branch of sound git tree.)
> 
> Previous and this one were (re)based on linux-next at the time of
> sending. I didn't really verify against for-next branch of sound git
> tree (I know I should).

linux-next should be fine.  The compress-offload 64bit timestamp
change was merged recently, so you might have missed it when you
created the patch.


thanks,

Takashi